Add missing OCIO include in RenderView.cpp#2780
Merged
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom Feb 21, 2026
Merged
Add missing OCIO include in RenderView.cpp#2780jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist adds a missing include of `OcioColorManagementSystem.h` in `RenderView.cpp`, which is required when building the Graph Editor with OCIO support.
I tested on FreeBSD 15.0. It is ok. |
Member
Author
|
Thanks for the validation, @Martinfx. I'm CC'ing @JGamache-autodesk for visibility, though I believe he's currently on sabbatical. I'll keep this PR open for a bit longer for the community to weigh in, and if there are no objections, let's plan to merge it for MaterialX v1.39.5. |
jstone-lucasfilm
merged commit 4619e73
into
AcademySoftwareFoundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist adds a missing include of
OcioColorManagementSystem.hinRenderView.cpp, which is required when building the Graph Editor with OCIO support.